Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted Speakers class to function #240

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

alicetran1221
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@alanchangxyz alanchangxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff 😎

I left a few comments with stuff that should be looked at/changed before this gets merged in. It's just a few minor things but feel free to ask if you have questions about any of them

src/app/components/speakers/speakers.js Outdated Show resolved Hide resolved
src/app/components/speakers/speakers.js Outdated Show resolved Hide resolved
src/app/components/speakers/speakers.js Outdated Show resolved Hide resolved
<p className="subheader">Panelists</p>
{renderSpeakers(speakersData.panelists)}
</div>
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(small thing) be sure to add semicolons after statements like returns, variable declarations, etc.; it's neater with them in 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the suggestions! I just pushed the changes so let me know if anything else needs to be changed.

Copy link
Collaborator

@alanchangxyz alanchangxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work taking this on for your first task 😄

@alanchangxyz alanchangxyz changed the base branch from master to main April 2, 2024 04:50
@alanchangxyz alanchangxyz merged commit fbc5963 into main Apr 2, 2024
@alanchangxyz alanchangxyz deleted the speakers-function branch April 2, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants